ashb commented on a change in pull request #21806:
URL: https://github.com/apache/airflow/pull/21806#discussion_r814601163
##########
File path:
airflow/migrations/versions/c306b5b5ae4a_switch_xcom_table_to_use_run_id.py
##########
@@ -41,7 +41,7 @@
def _get_new_xcom_columns() -> Sequence[Column]:
return [
- Column("dagrun_id", Integer(), nullable=False),
+ Column("dag_run_id", Integer(), nullable=False),
Review comment:
I think I'm with TP on this. Yes the table is "dag_run", but by keeping
this as "dagrun_id" it is (marginally) clearer that this is the "id" column of
the "dagrun" table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
