ashb commented on a change in pull request #21798:
URL: https://github.com/apache/airflow/pull/21798#discussion_r816138782



##########
File path: airflow/operators/trigger_dagrun.py
##########
@@ -43,14 +48,27 @@ class TriggerDagRunLink(BaseOperatorLink):
 
     name = 'Triggered DAG'
 
-    def get_link(self, operator, dttm):
+    def get_link(
+        self,
+        operator: "AbstractOperator",
+        dttm: Optional[datetime.datetime] = None,
+        *,
+        ti_key: Optional["TaskInstanceKey"] = None,
+    ) -> str:

Review comment:
       Oh,
   
   ```
   airflow/operators/trigger_dagrun.py:51: error: Signature of "get_link"
   incompatible with supertype "BaseOperatorLink"  [override]
           def get_link(
           ^
   ```
   
   Maybe the override doesn't actually hurts us here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to