potiuk commented on a change in pull request #21825:
URL: https://github.com/apache/airflow/pull/21825#discussion_r817958304
##########
File path: .github/workflows/build-images.yml
##########
@@ -233,6 +233,14 @@ jobs:
run: ./scripts/ci/images/ci_build_ci_image_on_ci.sh
- name: "Push CI image ${{ matrix.python-version }}:${{
env.GITHUB_REGISTRY_PUSH_IMAGE_TAG }}"
run: ./scripts/ci/images/ci_push_ci_images.sh
+ - name: >
+ Push empty CI images to finish waiting jobs:
+ ${{ matrix.python-version }}:${{ env.GITHUB_REGISTRY_PUSH_IMAGE_TAG
}}"
+ if: failure() || cancelled()
+ run: ./scripts/ci/images/ci_push_empty_ci_images.sh
Review comment:
The script did not work anyway (not sure if you remember but we
discussed it and even tried to fix it some time ago but it kept on cancelling
other stuff (I can find PR and Revert if you want).
The current script does not work and produces this:
<img width="918" alt="Screenshot 2022-03-02 at 18 58 09"
src="https://user-images.githubusercontent.com/595491/156420575-f0deb890-bee9-4ed6-a30a-1081a421de32.png";>
Example here:
https://github.com/apache/airflow/runs/5393691536?check_suite_focus=true#step:2:1
And since this is all about failing the image build, I figured it might be a
good one to fix it and I figured that pushing empty image is much better way of
"communication" with the script that waits for it. It's 100% accurate and FAR
simpler.
But I can separate it out if you think it would be better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/595491/156420575-f0deb890-bee9-4ed6-a30a-1081a421de32.png"](https://user-images.githubusercontent.com/595491/156420575-f0deb890-bee9-4ed6-a30a-1081a421de32.png"){kind=link}