kaxil commented on a change in pull request #21938:
URL: https://github.com/apache/airflow/pull/21938#discussion_r818599641
##########
File path: tests/www/views/test_views_acl.py
##########
@@ -190,11 +190,12 @@ def test_permission_exist(acl_app):
perms_views = acl_app.appbuilder.sm.get_resource_permissions(
acl_app.appbuilder.sm.get_resource('DAG:example_bash_operator'),
)
- assert len(perms_views) == 2
+ assert len(perms_views) == 3
perms = {str(perm) for perm in perms_views}
assert "can read on DAG:example_bash_operator" in perms
assert "can edit on DAG:example_bash_operator" in perms
+ assert "can delete on DAG:example_bash_operator" in perms
Review comment:
We probably need one more test as we have in
https://github.com/apache/airflow/pull/20346/files#diff-81ef48c7266f1690897901984c78693b82eaef73c99d54c738782fc9541202ceR211-R219
to be sure, that User can:
a) delete a DAG if they just have `DAG.can_delete`
b) delete a DAG if they just have `DAG:<dag_id>.can_delete` (and not
`DAG.can_delete` )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
