dstandish commented on a change in pull request #22102:
URL: https://github.com/apache/airflow/pull/22102#discussion_r822806004



##########
File path: airflow/cli/cli_parser.py
##########
@@ -1359,8 +1359,20 @@ class GroupCommand(NamedTuple):
     ActionCommand(
         name='upgrade',
         help="Upgrade the metadata database to latest version",
+        description=(
+            "Upgrade the schema of the metadata database. "
+            "To print but not execute commands, use option `--sql-only`. "

Review comment:
       > Should we name this --sql? closer to alembic offline migration command
   
   I don't think so.  As a user, think of UX.  they don't use alembic, in 
general. `sql` alone does not tell you enough about what it's doing.  the 
"only" signifies that it's "only" sql and not also something else  -- namely 
running the migrations.
   
   i'd be ok with `show-only` or `show-sql-only` if that's what the group 
prefers but i don't think `sql` alone is ok.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to