ulsc commented on a change in pull request #22179:
URL: https://github.com/apache/airflow/pull/22179#discussion_r825408162
##########
File path: airflow/providers/google/suite/hooks/drive.py
##########
@@ -180,12 +180,25 @@ def get_file_id(self, folder_id: str, file_name: str,
drive_id: Optional[str] =
file_metadata = {"id": files['files'][0]['id'], "mime_type":
files['files'][0]['mimeType']}
return file_metadata
- def upload_file(self, local_location: str, remote_location: str) -> str:
+ def upload_file(
+ self,
+ local_location: str,
+ remote_location: str,
+ chunk_size: int = 104857600,
Review comment:
I'm trying to understand this part also:
> :param chunk_size: File will be uploaded in chunks of this many bytes. Only
used if resumable=True. Pass in a value of -1 if the file is to
be
uploaded as a single chunk. Note that Google App Engine has a
5MB limit
on request size, so you should never set your chunksize larger
than 5MB,
or to -1.
If the chunk size shouldn't be larger than 5MB, why would they put 100MB as
default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
