[GitHub] [airflow] mik-laj commented on a change in pull request #22217: added docs about detailed network and constraints information

[GitBox]

mik-laj commented on a change in pull request #22217:
URL: https://github.com/apache/airflow/pull/22217#discussion_r825457299



##########
File path: airflow/providers/docker/operators/docker_swarm.py
##########
@@ -86,8 +86,19 @@ class DockerSwarmOperator(DockerOperator):
     :param mode: Indicate whether a service should be deployed as a replicated 
or global service,
         and associated parameters
     :param networks: List of network names or IDs or NetworkAttachmentConfig 
to attach the service to.
-    :param placement: Placement instructions for the scheduler. If a list is 
passed instead,
-        it is assumed to be a list of constraints as part of a Placement 
object.
+        NetworkAttachmentConfig object accepts following params:

Review comment:
       We already have a link to Docker API reference.
   <img width="932" alt="Screenshot 2022-03-13 at 15 29 50" 
src="https://user-images.githubusercontent.com/12058428/158064360-0a96c238-527d-4a15-a54f-d66cd705d4d8.png";>
   I am not sure if we need to duplicate this documentation as it can be 
maintenance burden




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org