potiuk commented on a change in pull request #22209:
URL: https://github.com/apache/airflow/pull/22209#discussion_r826141331



##########
File path: airflow/_vendor/README.md
##########
@@ -0,0 +1,37 @@
+# Vendor package
+
+## What vendored packages are for
+
+The `airlfow._vendor` package is foreseen for vendoring in packages, that we 
have to modify ourselves
+because authors of the packages do not have time to modify them themselves. 
This is often temporary
+and once the packages implement fixes that we need, and then we remove the 
packages from
+the _vendor package.
+
+All Vendored libraries must follow these rules:
+
+1. Vendored libraries must be pure Python--no compiling.

Review comment:
       This means that we should not vendor-in code that woudl requrire us to 
produce platform/architecture specific packaes (such as numpy etc.). Otherwise 
it will require from us to build multiple binary wheels for `airflow` core - 
where wa only need one pure-python only. 

##########
File path: airflow/_vendor/README.md
##########
@@ -0,0 +1,37 @@
+# Vendor package
+
+## What vendored packages are for
+
+The `airlfow._vendor` package is foreseen for vendoring in packages, that we 
have to modify ourselves
+because authors of the packages do not have time to modify them themselves. 
This is often temporary
+and once the packages implement fixes that we need, and then we remove the 
packages from
+the _vendor package.
+
+All Vendored libraries must follow these rules:
+
+1. Vendored libraries must be pure Python--no compiling.

Review comment:
       This means that we should not vendor-in code that woudl requrire us to 
produce platform/architecture specific packages (such as numpy etc.). Otherwise 
it will require from us to build multiple binary wheels for `airflow` core - 
where wa only need one pure-python only. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to