xyu edited a comment on pull request #21539: URL: https://github.com/apache/airflow/pull/21539#issuecomment-1067245016
> there should be a documentation explaining that it has changed in 2.3.0. I'm not quite sure what you mean @potiuk, as you pointed out in the original issue (https://github.com/apache/airflow/issues/20092#issuecomment-997431778) the precedence for configuration options is bare setting over `_cmd` or secret versions. This PR filters out the bare configs if they are set to Airflow’s built in defaults which then allows the user set `_cmd` overrides to work again. So this is really fixing a bug not adding or changing config behavior. (I mean I guess it is changing the config behavior but it's changing the behavior to an unbroken as documented state.) EDIT: Just to clarify with Airflow >= 2.2.1 when `as_dict()` was called if a "sensitive_config_values" had the bare value (e.g. `sql_alchemy_conn`) unset but a cmd or secret version of that set (e.g. `sql_alchemy_conn_cmd`) the dict produced by the `as_dict()` function would contain the Airflow default for the bare setting set. This in turn causes anything downstream, e.g. Airflow workers to ignore the cmd or secret version of that config and always use Airflow defaults. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
