dstandish commented on a change in pull request #22260:
URL: https://github.com/apache/airflow/pull/22260#discussion_r827459364
##########
File path: airflow/models/taskfail.py
##########
@@ -28,22 +29,42 @@ class TaskFail(Base):
__tablename__ = "task_fail"
id = Column(Integer, primary_key=True)
- task_id = Column(String(ID_LEN, **COLLATION_ARGS), nullable=False)
- dag_id = Column(String(ID_LEN, **COLLATION_ARGS), nullable=False)
- execution_date = Column(UtcDateTime, nullable=False)
+ task_id = Column(StringID(), nullable=False)
+ dag_id = Column(StringID(), nullable=False)
+ run_id = Column(StringID(), nullable=False)
+ map_index = Column(Integer, server_default='-1', nullable=False)
Review comment:
question @uranusjr @ashb ...
the uniqueness of these 4 attributes will be enforced through the foreign
key. do you think that we should also add a unique index though for
performance reasons?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
