potiuk opened a new pull request #22385: URL: https://github.com/apache/airflow/pull/22385
The execution_date -> run_id change (#21960) attempted to make it Airflow 2.1 backwards-compatible, but the problem is that in Airflo2 2.1 retrieving `run_id` attribute of TaskInstance throws AttributeError rather than returns None. It turns out that when you have a field defined in an ORM model, it will never throw AtributeError (even if you delete the attribute it will return None. Accesising `run_id` with getattr raises AttributeError in Airflow 2.1 (because there TaskInstance has no run_id defined). The test to test this behaviour is a little convoluted to account for this behaviour of ORM models in SQLAlchemy. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
