feng-tao commented on a change in pull request #5350: [AIRFLOW-4716] Instrument 
dag loading time duration
URL: https://github.com/apache/airflow/pull/5350#discussion_r289268103
 
 

 ##########
 File path: airflow/models/dagbag.py
 ##########
 @@ -391,6 +391,10 @@ def collect_dags(
             'dagbag_import_errors', len(self.import_errors), 1)
         self.dagbag_stats = sorted(
             stats, key=lambda x: x.duration, reverse=True)
+        for file_stat in self.dagbag_stats:
+            Stats.timing('dag.loading-duration.{}'.
+                         format(str([dag.dag_id for dag in file_stat.dags])),
 
 Review comment:
   thanks @XD-DENG . You are right:) Somehow I thought the last field is a 
list. PR updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to