[GitHub] [airflow] potiuk commented on a change in pull request #22385: Fix "run_id" k8s and elasticsearch compatibility with Airflow 2.1

Mon, 21 Mar 2022 02:56:54 -0700 


potiuk commented on a change in pull request #22385:
URL: https://github.com/apache/airflow/pull/22385#discussion_r830922586



##########
File path: airflow/providers/elasticsearch/log/es_task_handler.py
##########
@@ -129,7 +129,7 @@ def _render_log_id(self, ti: TaskInstance, try_number: int) 
-> str:
         return self.log_id_template.format(
             dag_id=ti.dag_id,
             task_id=ti.task_id,
-            run_id=ti.run_id,
+            run_id=ti.run_id if hasattr(ti, "run_id") else "",

Review comment:
       Hmm. I convinced mysefl :).
   
   It's better indeed, I think the default is "deliberate enough".
   
   
   
![image](https://user-images.githubusercontent.com/595491/159238762-39386fb0-3a5e-4f26-8e90-b6b6a59179c4.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to