eladkal commented on code in PR #22737:
URL: https://github.com/apache/airflow/pull/22737#discussion_r846658209
##########
airflow/providers/amazon/aws/sensors/s3.py:
##########
@@ -109,39 +152,18 @@ def get_hook(self) -> S3Hook:
return self.hook
-class S3KeySizeSensor(S3KeySensor):
- """
- Waits for a key (a file-like instance on S3) to be present and be more than
- some size in a S3 bucket.
- S3 being a key/value it does not support folders. The path is just a key
- a resource.
+def default_check_fn(data: List) -> bool:
Review Comment:
Why is this function not in the `S3KeySizeSensor` class?
can you please explain this change and how is it backward compatible?
I see you created the `howto_sensor_s3_key_function_definition` example but
reading the doc you just referenced it I think now that `S3KeySensor` has many
different capabilities we should list them in the doc and explain about them.
It wasn't so clear to me when reading it
##########
airflow/providers/amazon/aws/sensors/s3.py:
##########
@@ -109,39 +152,18 @@ def get_hook(self) -> S3Hook:
return self.hook
-class S3KeySizeSensor(S3KeySensor):
- """
- Waits for a key (a file-like instance on S3) to be present and be more than
- some size in a S3 bucket.
- S3 being a key/value it does not support folders. The path is just a key
- a resource.
+def default_check_fn(data: List) -> bool:
Review Comment:
Why is this function not in the `S3KeySizeSensor` class?
can you please explain this change and how is it backward compatible?
I see you created the `howto_sensor_s3_key_function_definition` example but
reading the doc you just referenced it I think now that `S3KeySensor` has
several different capabilities we should list them in the doc and explain about
them. It wasn't so clear to me when reading it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
