uranusjr commented on code in PR #22909: URL: https://github.com/apache/airflow/pull/22909#discussion_r847689404
########## airflow/models/mappedoperator.py: ########## @@ -559,7 +562,12 @@ def _get_map_lengths(self, run_id: str, *, session: Session) -> Dict[str, int]: for task_id, length in xcom_query: for mapped_arg_name in mapped_dep_keys[task_id]: map_lengths[mapped_arg_name] += length + return map_lengths + def _resolve_map_lengths(self, run_id: str, *, session: Session) -> Dict[str, int]: + """Return dict of argument name to map length, or throw if some are not resolvable""" + expansion_kwargs = self._get_expansion_kwargs() + map_lengths = self._get_map_lengths(run_id, session=session) Review Comment: We should document `_get_map_lengths` to explain how it’s different from `_resolve_map_lengths`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org