ashb commented on a change in pull request #5372: [AIRFLOW-3057] add prev_*_date_success to template context URL: https://github.com/apache/airflow/pull/5372#discussion_r291063488
########## File path: airflow/models/taskinstance.py ########## @@ -528,25 +532,43 @@ def _get_previous_ti(self, session=None): if not previous_scheduled_date: return None - return TaskInstance(task=self.task, - execution_date=previous_scheduled_date) + return TaskInstance(task=self.task, execution_date=previous_scheduled_date) dr.dag = dag - if dag.catchup: - last_dagrun = dr.get_previous_scheduled_dagrun(session=session) + if dag.catchup is False or state is not None or dag.schedule_interval is None: Review comment: Can you also confirm that the tests cover all three cases? (It's early and my ☕️ hasn't kicked in yet). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services