ashb commented on a change in pull request #5358: [AIRFLOW-4085] FileSensor - 
adding wildcard option
URL: https://github.com/apache/airflow/pull/5358#discussion_r291069065
 
 

 ##########
 File path: tests/contrib/sensors/test_file_sensor.py
 ##########
 @@ -74,10 +75,10 @@ def test_simple(self):
                      ignore_ti_state=True)
 
     def test_file_in_nonexistent_dir(self):
-        dir = tempfile.mkdtemp()
+        dir_ = tempfile.mkdtemp()
 
 Review comment:
   ```suggestion
           dir = tempfile.mkdtemp()
   ```
   
   The diff is much easier to read and easier to review if you don't make 
changes like this. Please revert it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to