dstandish commented on a change in pull request #5372: [AIRFLOW-3057] add
prev_*_date_success to template context
URL: https://github.com/apache/airflow/pull/5372#discussion_r291074453
##########
File path: airflow/models/taskinstance.py
##########
@@ -528,25 +532,43 @@ def _get_previous_ti(self, session=None):
if not previous_scheduled_date:
return None
- return TaskInstance(task=self.task,
- execution_date=previous_scheduled_date)
+ return TaskInstance(task=self.task,
execution_date=previous_scheduled_date)
dr.dag = dag
- if dag.catchup:
- last_dagrun = dr.get_previous_scheduled_dagrun(session=session)
+ if dag.catchup is False or state is not None or
dag.schedule_interval is None:
Review comment:
Re coverage yes these cases are covered that's what this part is doing:
``` schedule_interval_values = ('0 0 * * *', None,
datetime.timedelta(days=1))
catchup_values = (True, False)
for tuple_ in product(schedule_interval_values, catchup_values):
self._test_previous_dates(*tuple_, object_='previous_ti')
```
It's taking all combinations of the two lists and running the relevant tests
for each combination.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
