ashb commented on a change in pull request #5164: [AIRFLOW-4396] Provide a link
to external Elasticsearch logs in UI.
URL: https://github.com/apache/airflow/pull/5164#discussion_r291153132
##########
File path: airflow/www/views.py
##########
@@ -1265,6 +1283,7 @@ def set_duration(tid):
form = DateTimeWithNumRunsForm(data={'base_date': max_date,
'num_runs': num_runs})
+ external_logs = conf.get('elasticsearch', 'elasticsearch_frontend')
Review comment:
For future reference this should be
```suggestion
external_logs = conf.getboolean('elasticsearch',
'elasticsearch_frontend')
```
Wait, no it shouldn't. What am I talking about. (I just got confused by the
`bool(external_logs)` a few lines down.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
