potiuk commented on PR #23271: URL: https://github.com/apache/airflow/pull/23271#issuecomment-1110265175
I think there is a **slight** chance this one will affect some production deployments. This means that of the triggerer gets SIGINT (Ctrl+C) it **might** not close cleanly in the current versions of CPython. This is not likely to happen normally when Airflow run in unattended way (usually in such cases SIGTERM is used to terminate processes not SIGINT). But we cannot exclude it and also it makes it not really nice for any kind of debugging and manual running of airflow components. Maybe (@andrewgodwin @ashb @dstandish WDYT?) we could add some protection for that (if we all agree this is a likely reason) - I think that triggerer could simply add a custom SIGINT handler which would exist immediately, rather than print Keyboard Interrupt printing ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
