bbovenzi opened a new pull request, #23332:
URL: https://github.com/apache/airflow/pull/23332

   The Grid view wasn't checking DAG edit permissions. Also, the permission 
error body response is HTML, not json.
   
   - Check if `body` in `ConfirmDIalog` is an array to prevent the grid view 
from crashing
   - Add `canEdit` check to disabled all grid view action buttons, and don't 
show mapped instance selection at all
   
   <img width="996" alt="Screen Shot 2022-04-28 at 11 19 20 AM" 
src="https://user-images.githubusercontent.com/4600967/165787286-b25c1c2a-35d8-4c80-950d-789d8d966910.png";>
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragement file, named `{pr_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to