bbovenzi commented on code in PR #23332:
URL: https://github.com/apache/airflow/pull/23332#discussion_r861069996
##########
airflow/www/templates/airflow/dag.html:
##########
@@ -82,6 +82,9 @@
{% endif %}
{% if external_log_name is defined %}
<meta name="external_log_name" content="{{ external_log_name }}">
+ {% if appbuilder.sm.can_edit_dag(dag.dag_id) %}
+ <meta name="can_edit" content="{{ appbuilder.sm.can_edit_dag(dag.dag_id) }}">
Review Comment:
_More gracfully_, yes. The error response is still an html redirect. But the
UI won't crash.
I feel like fixing the error response from the webserver should be in
another PR?
##########
airflow/www/templates/airflow/dag.html:
##########
@@ -82,6 +82,9 @@
{% endif %}
{% if external_log_name is defined %}
<meta name="external_log_name" content="{{ external_log_name }}">
+ {% if appbuilder.sm.can_edit_dag(dag.dag_id) %}
+ <meta name="can_edit" content="{{ appbuilder.sm.can_edit_dag(dag.dag_id) }}">
Review Comment:
_More gracefully_, yes. The error response is still an html redirect. But
the UI won't crash.
I feel like fixing the error response from the webserver should be in
another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
