eladkal commented on PR #23326: URL: https://github.com/apache/airflow/pull/23326#issuecomment-1112681159
@mik-laj **For the first point:** I didn't remove all project references to `bigquery_conn_id`, `google_cloud_storage_conn_id`. I removed only those we set deprecation warning for. There are operators which should use them - all are in cases where we have two references to gcp conn so we can't just name it `gcp_conn_id` as it will be confusing. The [BigQueryCreateExternalTableOperator](https://github.com/apache/airflow/blob/d673c9dc86491a8edd88bc60b3ae9a6be2c3187d/airflow/providers/google/cloud/operators/bigquery.py#L889) This operator has `bigquery_conn_id` and `google_cloud_storage_conn_id`. You don't have to use the same conn for BigQuery and for GCS so it make sense to use different names to distinguish the two conns you can set. I guess that was also the mind set of previous contributors as they decided not to deprecated these con_ids in this specific operator/ I guess the PR title is a bit misleading I'll change it to `Remove deprecations of ...` Did I miss something else? **For the second point:** The gcs_to_s3 is in Aws not Google. The next release of Aws provider is not a major release so we can't remove it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
