potiuk commented on PR #20935:
URL: https://github.com/apache/airflow/pull/20935#issuecomment-1113185605

   > @potiuk I think can jump on that early next week. I am not familiar with 
the MyPy tooling though. I assume the origin of this change is due to the 
parameter not being optional? Would I then add back in a "violation" of your 
MyPy fixes? thinking
   
   Or maybe the way it worked before was accidental and not really 
supported/expected - in which case it is a no issue and it was simply wrongly 
used  - maybe there is another "proper" way of doing it - this is what I am 
referring to as "you are the one that can fix it". While I **think** MyPy 
changes were neutral, it could be it is really a problem with underlying 
library behaviour when None is passed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to