uranusjr commented on code in PR #23452:
URL: https://github.com/apache/airflow/pull/23452#discussion_r864022730
##########
airflow/hooks/dbapi.py:
##########
@@ -128,6 +131,15 @@ def get_pandas_df(self, sql, parameters=None, **kwargs):
with closing(self.get_conn()) as conn:
return psql.read_sql(sql, con=conn, params=parameters, **kwargs)
+ def get_pandas_df_by_chunks(self, sql, parameters=None, **kwargs):
Review Comment:
Let’s make this
```suggestion
def get_pandas_df_by_chunks(self, sql, parameters=None, *, chunksize,
**kwargs):
```
So this function is directly usable as public API and a user won’t pass
incorrect arguments in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
