potiuk commented on code in PR #23924:
URL: https://github.com/apache/airflow/pull/23924#discussion_r882686726
##########
airflow/www/views.py:
##########
@@ -258,7 +258,11 @@ def task_group_to_grid(task_item_or_group, dag, dag_runs,
session):
if isinstance(task_item_or_group, AbstractOperator):
return {
'id': task_item_or_group.task_id,
- 'instances': [wwwutils.get_task_summary(dr, task_item_or_group,
session) for dr in dag_runs],
+ 'instances': [
+ ts
+ for ts in (wwwutils.get_task_summary(dr, task_item_or_group,
session) for dr in dag_runs)
+ if ts is not None
+ ],
Review Comment:
> More type checking is always nice. I've been meaning to add typescript to
the UI.
Oh yeah. Absolutely. Typescript is soooo much better than plain javascript.
One thing that it makes easier - is for anyone to contribute more fixes in an
easy way. (once we have a built-in automation to transpile it, which is
super-easy with yarn etc). I think lack of typing support, autocomplete and
verification makes it really difficult for "newcomers" to reason about their
changes and it's so much easier to contribute small fixes there.
You somehow loose that when you get familiar, when you put yourselve in the
shoes of new contributor - it's a world of difference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
