eladkal commented on code in PR #23983:
URL: https://github.com/apache/airflow/pull/23983#discussion_r884151696
##########
airflow/operators/datetime.py:
##########
@@ -64,10 +66,16 @@ def __init__(
self.target_upper = target_upper
self.follow_task_ids_if_true = follow_task_ids_if_true
self.follow_task_ids_if_false = follow_task_ids_if_false
- self.use_task_execution_date = use_task_execution_date
+ self.use_task_logical_date = use_task_logical_date
+ if use_task_execution_date:
Review Comment:
I think `exactly_one` fits more to mutually exclusive + both are valid
options.
Here while we want mutually exclusive only 1 option is valid since the
other is deprecated.
Using `exactly_one` won't save us the if condition as we still need to raise
deprecation warning.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
