lmeerwood commented on code in PR #24311:
URL: https://github.com/apache/airflow/pull/24311#discussion_r892106393
##########
airflow/providers/google/cloud/transfers/oracle_to_gcs.py:
##########
@@ -45,15 +45,15 @@ class OracleToGCSOperator(BaseSQLToGCSOperator):
ui_color = '#a0e08c'
type_map = {
- cx_Oracle.DB_TYPE_BINARY_DOUBLE: 'DECIMAL',
- cx_Oracle.DB_TYPE_BINARY_FLOAT: 'DECIMAL',
- cx_Oracle.DB_TYPE_BINARY_INTEGER: 'INTEGER',
- cx_Oracle.DB_TYPE_BOOLEAN: 'BOOLEAN',
- cx_Oracle.DB_TYPE_DATE: 'TIMESTAMP',
- cx_Oracle.DB_TYPE_NUMBER: 'NUMERIC',
- cx_Oracle.DB_TYPE_TIMESTAMP: 'TIMESTAMP',
- cx_Oracle.DB_TYPE_TIMESTAMP_LTZ: 'TIMESTAMP',
- cx_Oracle.DB_TYPE_TIMESTAMP_TZ: 'TIMESTAMP',
+ oracledbbase.DB_TYPE_BINARY_DOUBLE: 'DECIMAL',
+ oracledbbase.DB_TYPE_BINARY_FLOAT: 'DECIMAL',
+ oracledbbase.DB_TYPE_BINARY_INTEGER: 'INTEGER',
+ oracledbbase.DB_TYPE_BOOLEAN: 'BOOLEAN',
+ oracledbbase.DB_TYPE_DATE: 'TIMESTAMP',
+ oracledbbase.DB_TYPE_NUMBER: 'NUMERIC',
+ oracledbbase.DB_TYPE_TIMESTAMP: 'TIMESTAMP',
+ oracledbbase.DB_TYPE_TIMESTAMP_LTZ: 'TIMESTAMP',
+ oracledbbase.DB_TYPE_TIMESTAMP_TZ: 'TIMESTAMP',
Review Comment:
I had that originally, but MyPy didn't like that. I'd get the following
error:
`error: Module has no attribute DB_TYPE_TIMESTAMP_TZ: 'TIMESTAMP'`. This was
the only way I could find to stop the error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
