dstandish commented on code in PR #23560: URL: https://github.com/apache/airflow/pull/23560#discussion_r901027524
########## docs/apache-airflow/security/secrets/secrets-backend/index.rst: ########## @@ -101,8 +143,8 @@ Roll your own secrets backend A secrets backend is a subclass of :py:class:`airflow.secrets.BaseSecretsBackend` and must implement either :py:meth:`~airflow.secrets.BaseSecretsBackend.get_connection` or :py:meth:`~airflow.secrets.BaseSecretsBackend.get_conn_value`. -After writing your backend class, provide the fully qualified class name in the ``backend`` key in the ``[secrets]`` -section of ``airflow.cfg``. +After writing your backend class, provide the fully qualified class name in the ``backend`` key or provide Review Comment: > I would rather for now add Depreciation warning in initialize_secrets_backends() and after think about how to solve all findings which listed above i understand the impulse but this does not make sense to me. it is hard to think through backcompat and deprecation and UX -- this is one of the challenges with open source. we should not have two ways of doing things and should not defer til "later" these problems. the right time to deal with deprecation of an "old" way of configuration is when you add the "new" way of configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
