jedcunningham commented on code in PR #24496:
URL: https://github.com/apache/airflow/pull/24496#discussion_r904358371
##########
airflow/config_templates/config.yml:
##########
@@ -1670,12 +1670,13 @@
or insert it into a database (depending of the backend)
This status is used by the scheduler to update the state of the task
The use of a database is highly recommended
+ When not specified, sql_alchemy_conn with db+ prefix will be used for
connection
Review Comment:
```suggestion
When not specified, sql_alchemy_conn with a db+ scheme prefix will
be used
```
##########
chart/values.yaml:
##########
@@ -319,7 +319,24 @@ extraEnvFrom: ~
# Airflow database & redis config
data:
# If secret names are provided, use those secrets
+ # These secrets must be created manually, eg:
+ #
+ # kind: Secret
+ # apiVersion: v1
+ # metadata:
+ # name: custom-airflow-metadata-secret
+ # type: Opaque
+ # data:
+ # connection: base64_encoded_connection_string
+
metadataSecretName: ~
+ # When providing secret names and using the same database for metadata and
+ # result backend, for Airflow < 2.4.0 it is necessary to create a separate
+ # secret for result backend but with db+ prefix in connection. For example:
+ # data:
+ # connection: base64_encoded_connection_string_with_db+_prefix
Review Comment:
```suggestion
# secret for result backend but with a db+ scheme prefix.
```
I don't think the inline example really adds much value? I also changed the
wording a bit (so it reads better to me at least).
##########
chart/values.yaml:
##########
@@ -319,7 +319,24 @@ extraEnvFrom: ~
# Airflow database & redis config
data:
# If secret names are provided, use those secrets
+ # These secrets must be created manually, eg:
+ #
+ # kind: Secret
+ # apiVersion: v1
+ # metadata:
+ # name: custom-airflow-metadata-secret
+ # type: Opaque
+ # data:
+ # connection: base64_encoded_connection_string
+
metadataSecretName: ~
+ # When providing secret names and using the same database for metadata and
+ # result backend, for Airflow < 2.4.0 it is necessary to create a separate
+ # secret for result backend but with db+ prefix in connection. For example:
+ # data:
+ # connection: base64_encoded_connection_string_with_db+_prefix
+ # For airflow >= 2.4.0 it is possible to not specify the secret,
+ # connection from metadataSecretName with db+ prefix will be used by default
Review Comment:
```suggestion
# For Airflow >= 2.4.0 it is possible to not specify the secret again,
# as Airflow will use sql_alchemy_conn with a db+ scheme prefix by default.
```
I think this reads better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
