ephraimbuddy commented on code in PR #24912:
URL: https://github.com/apache/airflow/pull/24912#discussion_r916531138
##########
airflow/jobs/scheduler_job.py:
##########
@@ -1194,7 +1195,7 @@ def _schedule_dag_run(
return callback_to_run
@provide_session
- def _verify_integrity_if_dag_changed(self, dag_run: DagRun, session=None):
+ def _verify_integrity_if_dag_changed(self, dag_run: DagRun, session:
Session = NEW_SESSION) -> None:
Review Comment:
I think the `provide_session` should be removed here. It's not used and it's
not proper to create a new session inside the scheduler loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
