potiuk commented on PR #24967: URL: https://github.com/apache/airflow/pull/24967#issuecomment-1180641621
> Probably should add some testing to make sure the wiring is correct down to session.mount? Yeah @jedcunningham I wanted to do it but. I found it difficult to test. This is very low level and it would actually require us to run HTTP server in process. The problem is tha "requests" mock does a not-nice trick of replacing whatever adapters you have with "Mock Adapter" so that you can test the "logic" of requests parameters. The TCPKeepAliveAdapter is rather low-level one. I could likely do some HTTP server and unit testing with it, but I am not sure if this is really worth it? WDYT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
