potiuk commented on code in PR #24967:
URL: https://github.com/apache/airflow/pull/24967#discussion_r921040537
##########
airflow/providers/http/sensors/http.py:
##########
@@ -91,15 +100,26 @@ def __init__(
self.headers = headers or {}
self.extra_options = extra_options or {}
self.response_check = response_check
-
- self.hook = HttpHook(method=method, http_conn_id=http_conn_id)
Review Comment:
That sounds good to me. Would be great to contribute such "best practicess
for writing Defferable Operators" to the community after all the experiences
Astronomer had with writing theirs. It would be a great contribution :).
Later on we could event try to automate some of those "best practices" in
pre-commits for any future community async operators. This sounds like a doable
task to ast-parse an operatort and if it is a Defferrable one, make sure no
self.hook is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
