norm commented on code in PR #25531:
URL: https://github.com/apache/airflow/pull/25531#discussion_r937590697
##########
airflow/models/dagrun.py:
##########
@@ -1158,7 +1158,7 @@ def _create_task_instances(
# TODO[HA]: We probably need to savepoint this so we can keep the
transaction alive.
session.rollback()
- def _find_missing_task_indexes(
+ def _find_missing_task_indexes_or_mark_removed(
Review Comment:
I'm not sure I can put into words why, but I don't like this function name
now. It sounds like it does two *different* actions, even though it's basically
"fix up if TI length has changed". And because I don't have the words, I also
can't suggest a better name. Helping! :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
