potiuk commented on PR #26109: URL: https://github.com/apache/airflow/pull/26109#issuecomment-1235324827
> > Why? If we REALLY want to split providers, we need to look at them in isolation. Each provider should be treated separately, independently from the others (this is one of the reasons we added common.sql to try various scenarios). > > If you look at common.sql in isolation - adding placeholder is a new feature, that trino, presto, sqlite might use to produce a bugfix release - and they should depend on this feature. > > Oh yeah very good point. It was late last night and I didn't think it through. Also. The current automation is very well prepared to handle this case. I am not sure if you are aware (I described it in the "procedure" but you can keep on rebasing this PR and regenerate the docs after each rebase and it should be cool even if new changes get merged over time. This is pretty normal to have the "docs" PR to go through several iterations and get some new PRs merged, so in order not to loose any new changes, always after rebasing it, you should regenerate the docs using: ``` breeze release-management prepare-provider-documentation --answer yes [packages] ``` This one will update the docs (and you will have to manually review the changed files and possibly move around the changelog entries, but the previous entries you already added are untouched so it works incrementally. This is based on the PR# not PR description so this gives also opportunity to update descriptions of the changelog in more meaninggful way (as long as you don't change (PR #) in parenthesis. For example in this case, it is perfectly ok (and that's what I'd do) to update the description of the PR in common.sql: In Trino/Presto/SQlite you would then have: ``` Bug Fixes ~~~~~~~~~ * ``Fix placeholders in 'TrinoHook', 'PrestoHook', 'SqliteHook' (#25939)`` ``` But in common SQL: ``` Features ~~~~~~~~~ * ``Add placeholders for SQL parameters (#25939)`` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
