hankehly commented on code in PR #26003:
URL: https://github.com/apache/airflow/pull/26003#discussion_r963185967
##########
airflow/providers/amazon/aws/sensors/rds.py:
##########
@@ -38,10 +38,10 @@ def __init__(self, *args, aws_conn_id: str = "aws_conn_id",
hook_params: Optiona
hook_params = hook_params or {}
self.hook = RdsHook(aws_conn_id=aws_conn_id, **hook_params)
self.target_statuses: List[str] = []
+ self.check_status_field = "Status"
Review Comment:
By adding if/else logic to the base class, we're making it "aware" of the
details of the subclass. I think a better approach is to let the subclass tell
us what it needs.
I checked the `botocore` documentation and it looks like "DBInstanceStatus"
and "Status" are the only 2 options, so I'll go ahead and make the change to
finish up this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
