jedcunningham commented on code in PR #26243:
URL: https://github.com/apache/airflow/pull/26243#discussion_r966263752
##########
Dockerfile.ci:
##########
@@ -1133,7 +1133,11 @@ RUN echo "Airflow version: ${AIRFLOW_VERSION}"
# * dill<0.3.3 required by apache-beam
# * pyarrow>=6.0.0 is because pip resolver decides for Python 3.10 to
downgrade pyarrow to 5 even if it is OK
# for python 3.10 and other dependencies adding the limit helps resolver to
make better decisions
-ARG EAGER_UPGRADE_ADDITIONAL_REQUIREMENTS="dill<0.3.3 pyarrow>=6.0.0"
+# We need to limit the protobuf library to < 4.21.0 because not all google
libraries we use
+# Are compatible with the new protobuf version. All the google python client
libraries need
Review Comment:
```suggestion
# are compatible with the new protobuf version. All the google python client
libraries need
```
##########
Dockerfile:
##########
@@ -1211,7 +1211,11 @@ ARG ADDITIONAL_PYTHON_DEPS=""
# * dill<0.3.3 required by apache-beam
# * pyarrow>=6.0.0 is because pip resolver decides for Python 3.10 to
downgrade pyarrow to 5 even if it is OK
# for python 3.10 and other dependencies adding the limit helps resolver to
make better decisions
-ARG EAGER_UPGRADE_ADDITIONAL_REQUIREMENTS="dill<0.3.3 pyarrow>=6.0.0"
+# We need to limit the protobuf library to < 4.21.0 because not all google
libraries we use
+# Are compatible with the new protobuf version. All the google python client
libraries need
Review Comment:
```suggestion
# are compatible with the new protobuf version. All the google python client
libraries need
```
super nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]