pavansharma36 commented on code in PR #27072:
URL: https://github.com/apache/airflow/pull/27072#discussion_r996448191
##########
airflow/models/trigger.py:
##########
@@ -201,10 +201,12 @@ def assign_unassigned(cls, triggerer_id, capacity,
session=None):
# notin_ doesn't find NULL rows
.filter(or_(cls.triggerer_id.is_(None),
cls.triggerer_id.notin_(alive_triggerer_ids)))
.limit(capacity)
+ .with_for_update(skip_locked=True)
.all()
)
- session.query(cls).filter(cls.id.in_([i.id for i in
trigger_ids_query])).update(
- {cls.triggerer_id: triggerer_id},
- synchronize_session=False,
- )
+ if trigger_ids_query:
+ session.query(cls).filter(cls.id.in_([i.id for i in
trigger_ids_query])).update(
+ {cls.triggerer_id: triggerer_id},
+ synchronize_session=False,
+ )
Review Comment:
@dstandish update with subquery targeting same table is not supported in
mysql.
Thats the reason I used locking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
