Taragolis commented on code in PR #27134: URL: https://github.com/apache/airflow/pull/27134#discussion_r1003572486
########## docs/apache-airflow-providers-amazon/secrets-backends/aws-ssm-parameter-store.rst: ########## @@ -67,9 +67,10 @@ you would want to store your connection at ``/airflow/connections/smtp_default`` Optionally you can supply a profile name to reference aws profile, e.g. defined in ``~/.aws/config``. The value of the SSM parameter must be the :ref:`connection URI representation <generating_connection_uri>` -of the connection object. +or in the :ref:`JSON Format <connection-serialization-json-example>` of the connection object. -In some cases, URI's you will need stored in Secrets Manager may not be intuitive, for example when using HTTP / HTTPS or SPARK, you may need URI's that will look like this: +In some cases, URI's you will need stored in AWS SSM Parameter Store may not be intuitive, Review Comment: I thought that initial author tried to highlight that Airflow connection URI not a specific connection URI. E.g. user expected that HTTP `https://example.org/path` would work however in Airflow we should use `http://https%3A%2F%2Fexample.org%2Fpath` There is also a link to example how to generate URI exists in current doc: https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#generating-connection-uri -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
