kazanzhy commented on code in PR #26944:
URL: https://github.com/apache/airflow/pull/26944#discussion_r1007433847
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -175,41 +207,26 @@ def get_pandas_df_by_chunks(self, sql, parameters=None,
*, chunksize, **kwargs):
yield from psql.read_sql(sql, con=conn, params=parameters,
chunksize=chunksize, **kwargs)
def get_records(
- self,
- sql: str | list[str],
- parameters: Iterable | Mapping | None = None,
- **kwargs: dict,
- ):
+ self, sql: str | list[str], parameters: Iterable | Mapping | None =
None
+ ) -> Any | list[Any]:
Review Comment:
I changed back from `sql: str = ""` to `sql: str | list[str] = ""`.
It seems strange but without it, I can't remove `# type: ignore[override]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
