dstandish commented on code in PR #27447:
URL: https://github.com/apache/airflow/pull/27447#discussion_r1010750989


##########
airflow/utils/cli.py:
##########
@@ -107,6 +113,10 @@ def wrapper(*args, **kwargs):
             finally:
                 metrics['end_datetime'] = datetime.utcnow()
                 cli_action_loggers.on_post_execution(**metrics)
+                if verbose:
+                    root_logger.setLevel(logging.NOTSET)
+                    for handler in root_logger.handlers:
+                        handler.setLevel(logging.NOTSET)

Review Comment:
   does it need to unset? isn't the process always going to exit here anyway?  
then it won't matter.
   
   i guess the only case is when user is calling this from python....  but do 
we care about that case?  
   
   if we do care, is it sufficient to just unset?  or do we have to keep track 
of what it was before, and set it back to that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to