dstandish commented on code in PR #26766:
URL: https://github.com/apache/airflow/pull/26766#discussion_r1017034008
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -347,6 +350,10 @@ def _get_namespace(self) -> str | None:
return self._get_field("namespace")
return None
+ def get_xcom_sidecar_container_image(self):
+ """Returns the xcom sidecar image that defined in the connection"""
+ return self._get_field("xcom_sidecar_container_image") or None
Review Comment:
```suggestion
return self._get_field("xcom_sidecar_container_image")
```
this is handled by get_field
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -91,6 +91,9 @@ def get_connection_form_widgets() -> dict[str, Any]:
"cluster_context": StringField(lazy_gettext("Cluster context"),
widget=BS3TextFieldWidget()),
"disable_verify_ssl": BooleanField(lazy_gettext("Disable SSL")),
"disable_tcp_keepalive": BooleanField(lazy_gettext("Disable TCP
keepalive")),
+ "xcom_sidecar_container_image": StringField(
+ lazy_gettext("Xcom sidecar image"), widget=BS3TextFieldWidget()
Review Comment:
```suggestion
lazy_gettext("XCom sidecar image"),
widget=BS3TextFieldWidget()
```
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -91,6 +91,9 @@ def get_connection_form_widgets() -> dict[str, Any]:
"cluster_context": StringField(lazy_gettext("Cluster context"),
widget=BS3TextFieldWidget()),
"disable_verify_ssl": BooleanField(lazy_gettext("Disable SSL")),
"disable_tcp_keepalive": BooleanField(lazy_gettext("Disable TCP
keepalive")),
+ "xcom_sidecar_container_image": StringField(
Review Comment:
can you please add to doc here
docs/apache-airflow-providers-cncf-kubernetes/connections/kubernetes.rst
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
