bolkedebruin commented on PR #27540: URL: https://github.com/apache/airflow/pull/27540#issuecomment-1310151712
> I'm also worried about this changing how existing XCom JSON objects are deserialized -- i.e. before something was just treated as a plain JSON object, but now if it happens to have `__type` key in it then deserialization would fail. Small correction: if it has '__classname' as a key deserialization would fail. True, but how big is that risk? If would only happen for xcom values that are custom created or a dictionary that contains '__classname'. What I can do is raise an AttributeError if one tries to serialize with a '__classname' key but the input is a non attr decorated class. I'll add an additional check against `__version` in the deserializer. Chances that a dict would have `__classname` and `__version` specified and is not derserializable are really slim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
