dstandish commented on PR #27514: URL: https://github.com/apache/airflow/pull/27514#issuecomment-1317720914
I'm a little skeptical about `Merge SnowflakeHook.run and TrinoHook.run to DbApiHook.run` simply because there isn't clear utility apart from maybe consolidating shared code between two hooks. But we don't add to the base hook every time two subclasses share any code. And it's unclear to me anyway that this particular feature is actually useful / a good idea. But if you think there's a valuable interface to add, nothing wrong with opening the PR. Might make sense to do new PR for it though and just close this one. Then we can examine the interface from the simple perspective of... is this a feature we want to add to DbApiHook. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
