dstandish commented on code in PR #27736:
URL: https://github.com/apache/airflow/pull/27736#discussion_r1027038834
##########
airflow/kubernetes/pod_generator.py:
##########
@@ -445,29 +455,27 @@ def make_unique_pod_id(pod_id: str) -> str | None:
r"""
Kubernetes pod names must consist of one or more lowercase
rfc1035/rfc1123 labels separated by '.' with a maximum length of 253
- characters. Each label has a maximum length of 63 characters.
+ characters.
Name must pass the following regex for validation
``^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$``
+ (But note that this method actually doesn't guarantee that!)
Review Comment:
it's not really asserted. But it follows from a consequence of using
slugify in `create_pod_id`. And the behavior of that function is tested.
This one just adds a random suffix. So it assumes whatever it's given is
already valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
