[GitHub] [airflow] uranusjr commented on a diff in pull request #27808: Improve filtering for invalid schemas in Hive hook

Sun, 20 Nov 2022 19:15:46 -0800 


uranusjr commented on code in PR #27808:
URL: https://github.com/apache/airflow/pull/27808#discussion_r1027508096


##########
tests/providers/apache/hive/hooks/test_hive.py:
##########
@@ -133,10 +133,12 @@ def test_run_cli(self, mock_popen, mock_temp_dir):
         )
 
     def test_hive_cli_hook_invalid_schema(self):
-        with pytest.raises(RuntimeError):
+        with pytest.raises(RuntimeError) as error:
             hook = InvalidHiveCliHook()
             hook.run_cli("SHOW DATABASES")
 
+        assert ";" in str(error.value)

Review Comment:
   It’s better to check the entire error message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to