potiuk commented on code in PR #27720:
URL: https://github.com/apache/airflow/pull/27720#discussion_r1032702982


##########
airflow/jobs/scheduler_job.py:
##########
@@ -1291,7 +1291,9 @@ def _schedule_dag_run(
             self.log.error("Execution date is in future: %s", 
dag_run.execution_date)
             return callback
 
-        self._verify_integrity_if_dag_changed(dag_run=dag_run, session=session)
+        if not self._verify_integrity_if_dag_changed(dag_run=dag_run, 
session=session):
+            self.log.warning("The DAG disappeared before verifying integrity: 
%s. Skipping.", dag_run.dag_id)

Review Comment:
   I think this is fine to show the warning. This is a really, really rare race 
condition. - and realy intermittent and it can at least give  our user an 
indication and notice that something is wrong.
   
   If we make it ito debug - we will never see it. And when user is asked for 
logs, there wil never be any suspicious thing there.
   
   I think it should be a warning. just to let us know somthing strange is 
happening.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to