vincbeck commented on code in PR #27947:
URL: https://github.com/apache/airflow/pull/27947#discussion_r1039747336


##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -46,3 +48,73 @@ class 
RedshiftDataHook(AwsGenericHook["RedshiftDataAPIServiceClient"]):
     def __init__(self, *args, **kwargs) -> None:
         kwargs["client_type"] = "redshift-data"
         super().__init__(*args, **kwargs)
+
+    def execute_query(
+        self,
+        database: str,
+        sql: str | list[str],
+        cluster_identifier: str | None = None,
+        db_user: str | None = None,
+        parameters: list | None = None,
+        secret_arn: str | None = None,
+        statement_name: str | None = None,
+        with_event: bool = False,
+        await_result: bool = True,

Review Comment:
   Oh yeah good point. We can either rename it but it has to go through 
deprecation pattern first (since it is breaking change) or leave it as is. I am 
fine keeping it as is



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to