syedahsn commented on code in PR #27784:
URL: https://github.com/apache/airflow/pull/27784#discussion_r1040279833
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -502,6 +503,10 @@ class EmrServerlessCreateApplicationOperator(BaseOperator):
Its value must be unique for each request.
:param config: Optional dictionary for arbitrary parameters to the boto
API create_application call.
:param aws_conn_id: AWS connection to use
+ :param waiter_countdown: Total amount of time, in seconds, the operator
will wait for
+ the application to start. Defaults to 25 minutes.
+ :param waiter_check_interval_seconds: Number of seconds between polling
the state of the application.
+ Defaults to 60 seconds.
Review Comment:
No you're correct in that when `EmrServerlessCreateApplicationOperator` is
used, `waiter` can be called potentially twice, but definitely once. The first
time, it will wait for the application to be in `CREATED` state, and it will
use `waiter_countdown` and `waiter_check_interval_seconds`. If
`wait_for_completion` is `True`, it will call waiter again and wait for the
application to be in `STARTED` state.
For the `EmrServerlessStartJobOperator`, the waiter could potentially be
called twice as well, but may not be called at all depending on whether the
application is in a `Started` state or not. I added a change in the doc string
to reflect this. Let me know if it is unclear. Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
