uranusjr commented on code in PR #28113:
URL: https://github.com/apache/airflow/pull/28113#discussion_r1040755594
##########
airflow/cli/cli_parser.py:
##########
@@ -540,9 +540,18 @@ def string_lower_type(val):
)
ARG_IGNORE_DEPENDS_ON_PAST = Arg(
("-I", "--ignore-depends-on-past"),
- help="Ignore depends_on_past dependencies (but respect upstream
dependencies)",
+ help="Deprecated -- use `--depends-on-past ignore` instead. "
+ "Ignore depends_on_past dependencies (but respect upstream dependencies)",
action="store_true",
)
Review Comment:
I just realised we could improve this further by doing
`dest="depends_on_past", action="store_const", const="check"` here and merge
the two arguments. We can do this here or in a subsequent PR.
We should probably also make the two arguments mutually exclusive
(`add_mutually_exclusive_group`), although I’m not quite sure how that can be
done with how Airflow manages arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
